Add optional server variable #14
Conversation
There was a problem hiding this comment.
Thank you for the PR!
Can you please adjust the code a little:
I think host would be a better fit for the property than server. Can you rename that?
And please remove the changes in the default configuration file. We will address this in the documentation, as it seems be a bit confusing to have a null value in the default configuration.
|
Sure :) Changed to host and i removed the line from the default config file. |
|
@mpociot I needed to use this today and I noticed this remains undocumented in the docs.. I think it would be useful to add it. I also think it would be useful to be able to set the port as part of the app config rather than having to remember which port which app is on and change it manually in the input box |
This PR fixes #12
It is now possible to easily configure the server, which the dashboard connects to.
My setup is the following:
I have one server (the webserver) which is hosting the dashboard: dev.my.app
The socket server is running under ws-dev.my.app
Without this PR, the dashboard tries to conntect to dev.my.app because, in the connect section
window.location.hostnameis used. This behavior is after this pr still the same, except someone fills the new 'server' configuration variable. Then this value will be used.