Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Fix for dependency upgrade #223

Merged
merged 3 commits into from
Jul 28, 2019
Merged

Fix for dependency upgrade #223

merged 3 commits into from
Jul 28, 2019

Conversation

gabrieliuga
Copy link
Contributor

fixing issue #222

  • DnsResolver no longer extends React/Dns/Resolver as it's now a final class
  • StartWebSocketServer:getDnsResolver returns ResolverInterface to comply with new react/dns policy

@gabrieliuga
+ DnsResolver no longer extends React/Dns/Resolver as it's now a fina…
6b7b28d 
…l class

+ StartWebSocketServer:getDnsResolver returns ResolverInterface to comply with new react/dns policy
@gabrieliuga
+ organize imports
0660553
@gabrieliuga
+ organize imports
1c851f5
@anthonyvancauwenberghe
Copy link
Contributor

Add this to the composer file please:
react/dns:^1.1

The resolverinterface is newly introduced in 1.1. This to avoid that people who are on react/dns 1.0 get issues.

@anthonyvancauwenberghe anthonyvancauwenberghe mentioned this pull request Jul 26, 2019
Closed
@TheBigK
Copy link

TheBigK commented Jul 28, 2019

Will this be merged in the main branch?

@gabrieliuga
Copy link
Contributor Author

Waiting for @mpociot to accept/deny the request.

@mpociot mpociot merged commit 94fb667 into beyondcode:master Jul 28, 2019
@mpociot
Copy link
Member

mpociot commented Jul 28, 2019

Thank you!

anthonyvancauwenberghe added a commit to anthonyvancauwenberghe/laravel-websockets that referenced this pull request Jul 28, 2019
@anthonyvancauwenberghe
update react dns to v1.1
4dd9950 
The resolverinterface (used in beyondcode#223)  was newly introduced in reach/dns 1.1. This PR to avoid that people who are on react/dns 1.0 get issues.
@anthonyvancauwenberghe anthonyvancauwenberghe mentioned this pull request Jul 28, 2019
Merged
mpociot pushed a commit that referenced this pull request Jul 28, 2019
@anthonyvancauwenberghe @mpociot
update react dns to v1.1 (#227)
0ffc19a 
The resolverinterface (used in #223)  was newly introduced in reach/dns 1.1. This PR to avoid that people who are on react/dns 1.0 get issues.
@WyriHaximus WyriHaximus mentioned this pull request Jul 28, 2019
Closed
@TheBigK
Copy link

TheBigK commented Jul 29, 2019

We'll still have to wait till a new version of laravel-websockets is released, right? I tried updating but it still throws the same issue.

@anthonyvancauwenberghe
Copy link
Contributor

@mpociot please publish a new release the package is broken at the moment

@ereztdev
Copy link

Can anyone please paste the build I should require to fix beyondcode/laravel-websockets package issue? I am currently on version ^1.1 and it has breaking changes.

@anthonyvancauwenberghe
Copy link
Contributor

Dev-master :p

@judahnator
Copy link

Any movement on this? Been broken for quite some time...

@gabrieliuga
Copy link
Contributor Author

use dev-master in composer.json to grab the fix as there is no release yet with the fix
composer require beyondcode/laravel-websockets:dev-master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabrieliuga @anthonyvancauwenberghe @TheBigK @mpociot @ereztdev @judahnator