This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Fix docblocks in App #499
Merged
Fix docblocks in App #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frankly, I don't understand why the typing was removed from these methods in beyondcode#471, seems like a strange decision.
|
The concern was linked to the fact that users might want to use strings for app ids/keys/secrets instead of integers, as they were initially stated in the docblocks. |
|
Ok we can do string|int for the id then |
|
I'm sure there's other places that have these docblock hints for the app ID, hopefully you don't mind going through those yourself - I don't have my IDE set up for this project right now so I kinda wanted to just do this to nudge you in the right direction, just made these changes directly in github 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frankly, I don't understand why the typing was removed from these methods in #471, seems like a strange decision.
mixedis almost never the right thing to use.