Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Fix test suite #528

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Fix test suite #528

merged 2 commits into from
Sep 15, 2020

Conversation

stayallive
Copy link
Contributor

@stayallive stayallive commented Sep 15, 2020

Do not test Laravel 8 on PHP 7.2.

Master is now failing including any new PR because Laravel 8 requires PHP 7.3+.

As a bonus I removed some PHP extension that are not needed to run the testsuite speeding up the suite a bit.

@stayallive stayallive marked this pull request as ready for review September 15, 2020 14:20
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020

Codecov Report

Merging #528 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #528   +/-   ##
=========================================
  Coverage     47.60%   47.60%           
  Complexity      283      283           
=========================================
  Files            50       50           
  Lines          1126     1126           
=========================================
  Hits            536      536           
  Misses          590      590           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00dd9b0...0b0c843. Read the comment docs.

@rennokki rennokki merged commit 331a127 into beyondcode:master Sep 15, 2020
@stayallive stayallive deleted the feature/fix-test-suite branch September 15, 2020 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants