Skip to content

Conversation

dianjuar
Copy link
Member

@dianjuar dianjuar commented Feb 18, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Both workspaces were tested Angular and Nx (for bug fixes/features)

What is the current behavior?

Currently there is no support for nx@14

fix #469

What is the new behavior?

nx@14 and @15 supported 👍
Both nx 14 and 15 were manually tested, and everything worked as expected.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

CC @samuelfernandez @dgonzalezr

Offer support to nx V14. It was not supported on ngx-deploy-npm@5.0.0

fix #469
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dianjuar dianjuar merged commit 2d4455b into main Feb 18, 2023
@dianjuar dianjuar deleted the support-nx-14 branch February 18, 2023 05:31
@samuelfernandez
Copy link

This is great, good job @dianjuar!!

@dianjuar dianjuar mentioned this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install latest version (v4.3.11) in an Nx 14.x workspace
2 participants