Skip to content

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 5, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.3)

Can you help keep this open source service alive? 💖 Please sponsor : )

sunank200 and others added 8 commits September 5, 2025 16:41
Make TaskInstanceState and DagRunState public in task-sdk (#54945)
* Fix: Clean up FAB permissions when deleting DAGs (#50905)
This commit adds cleanup logic to the delete_dag function to:
- Remove DAG-specific resources from ab_view_menu table
- Clean up associated permissions and role associations

* test: Add comprehensive tests for DAG permission cleanup
Test Coverage:
- Non-FAB auth manager scenarios (graceful skip)
- FAB provider unavailable scenarios (import error handling)
- Full cleanup process with mocked FAB models
- Integration with delete_dag function
- Edge cases (non-existent DAGs)

* fix: clean up DAG permissions when deleting DAGs
- : Simplified core logic using auth manager delegation

- : Added cleanup_dag_permissions method

- : New specialized module for FAB permission cleanup

- Enhanced test coverage for multiple auth manager scenarios

* feat(fab-auth-manager): replace automatic DAG permission cleanup with CLI command
Replace automatic cleanup of DAG permissions during DAG deletion with a new CLI command
approach as requested in code review. This gives operators explicit control over when
and how DAG permissions are cleaned up.

* feat(fab): Update DAG permissions cleanup to SQLAlchemy 2.0 and improve tests
- Replace deprecated session.query() with session.scalars(select()) and session.execute(delete())
- Update permissions_command.py to use SQLAlchemy 2.0 syntax for better future compatibility
- Rewrite test_permissions_command.py to use integration tests instead of fragile mocks

* feat(fab): add missing test_dag_permissions.py
Add unit tests for dag_permissions module to satisfy project structure
requirements

* refactor(fab): Consolidate DAG permissions code and modernize patterns
- Replace hardcoded resource strings with constants in permissions_command.py
  - Use RESOURCE_DAG_PREFIX and RESOURCE_DETAILS_MAP for DAG Run
  - Remove deprecated Task Instance resource handling
- Change to session handling with @provide_session decorator
- Replace manual boolean parsing with airflow.utils.strings.to_boolean
- Consolidate dag_permissions.py functionality into permissions_command.py
- Consolidate test files for better maintainability

* test: enhance FAB permissions tests with function verification and real database operations
1. Function call verification (TestPermissionsCommand)
  - Replace stdout-only testing with precise function call verification
  - Add mock assertions for cleanup_dag_permissions with exact parameters
2. Real database operations (TestDagPermissions):
  - Replace mock-heavy approach with actual database interactions
  - Use real Resource, Action, and Permission entities with constraint handling
* add has_import_errors filter

* add unit tests

* update test

* add description

* Update airflow-core/src/airflow/api_fastapi/common/parameters.py

Change DAGs to Dags

Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>

* empty commit

* Change DAGs to dags

* Change DAGs to dags

---------

Co-authored-by: Guangyang Li <mail@guangyangli.com>
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
…ag (#55288)

Remove string serialization of python_callable in mapped tasks partial_kwargs.
This reduces the serialized Dag size.
@pull pull bot locked and limited conversation to collaborators Sep 5, 2025
@pull pull bot added the ⤵️ pull label Sep 5, 2025
@pull pull bot merged commit fb81e57 into boost-entropy-python:main Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants