feat(utils/noop): add noop() util (#2892)

jacobmllr95 · web-flow · commit 61b75dc6ecee · 2019-03-22T00:55:22.000+01:00
* feat(utils/noop): add `noop()` util

* fix noop reference
diff --git a/src/components/carousel/carousel.js b/src/components/carousel/carousel.js
@@ -1,5 +1,6 @@
 import observeDom from '../../utils/observe-dom'
 import KeyCodes from '../../utils/key-codes'
+import noop from '../../utils/noop'
 import {
   selectAll,
   reflow,
@@ -28,7 +29,7 @@ const DIRECTION = {
 const TRANS_DURATION = 600 + 50
 
 // Time for mouse compat events to fire after touch
-const TOUCHEVENT_COMPAT_WAIT = 500
+const TOUCH_EVENT_COMPAT_WAIT = 500
 
 // Number of pixels to consider touch move a swipe
 const SWIPE_THRESHOLD = 40
@@ -50,7 +51,7 @@ const TransitionEndEvents = {
 const EventOptions = { passive: true, capture: false }
 
 // Return the browser specific transitionEnd event name
-function getTransisionEndEvent(el) {
+function getTransitionEndEvent(el) {
   for (const name in TransitionEndEvents) {
     if (el.style[name] !== undefined) {
       return TransitionEndEvents[name]
@@ -61,8 +62,6 @@ function getTransisionEndEvent(el) {
   return null
 }
 
-const noop = () => {}
-
 // @vue/component
 export default {
   name: 'BCarousel',
@@ -194,7 +193,7 @@ export default {
   },
   mounted() {
     // Cache current browser transitionend event name
-    this.transitionEndEvent = getTransisionEndEvent(this.$el) || null
+    this.transitionEndEvent = getTransitionEndEvent(this.$el) || null
     // Get all slides
     this.updateSlides()
     // Observe child changes so we can update slide list
@@ -205,7 +204,7 @@ export default {
       attributeFilter: ['id']
     })
   },
-  beforeDestroy() /* istanbul ignore next: dificult to test */ {
+  beforeDestroy() /* istanbul ignore next: difficult to test */ {
     clearTimeout(this._animationTimeout)
     clearTimeout(this._touchTimeout)
     clearInterval(this._intervalId)
@@ -217,7 +216,7 @@ export default {
     // Set slide
     setSlide(slide, direction = null) {
       // Don't animate when page is not visible
-      /* istanbul ignore if: dificult to test */
+      /* istanbul ignore if: difficult to test */
       if (inBrowser && document.visibilityState && document.hidden) {
         return
       }
@@ -261,7 +260,7 @@ export default {
       if (!evt) {
         this.isPaused = false
       }
-      /* istanbul ignore next: most likley will never happen, but just in case */
+      /* istanbul ignore next: most likely will never happen, but just in case */
       if (this._intervalId) {
         clearInterval(this._intervalId)
         this._intervalId = null
@@ -271,9 +270,9 @@ export default {
         this._intervalId = setInterval(this.next, Math.max(1000, this.interval))
       }
     },
-    // Re-Start auto rotate slides when focus/hover leaves the carousel
+    // Restart auto rotate slides when focus/hover leaves the carousel
     restart(evt) {
-      /* istanbul ignore if: dificult to test */
+      /* istanbul ignore if: difficult to test */
       if (!this.$el.contains(document.activeElement)) {
         this.start()
       }
@@ -314,7 +313,7 @@ export default {
         addClass(nextSlide, dirClass)
         // Transition End handler
         let called = false
-        /* istanbul ignore next: dificult to test */
+        /* istanbul ignore next: difficult to test */
         const onceTransEnd = evt => {
           if (called) {
             return
@@ -347,7 +346,7 @@ export default {
           const events = this.transitionEndEvent.split(/\s+/)
           events.forEach(event => eventOn(currentSlide, event, onceTransEnd, EventOptions))
         }
-        // Fallback to setTimeout
+        // Fallback to setTimeout()
         this._animationTimeout = setTimeout(onceTransEnd, TRANS_DURATION)
       }
       if (isCycling) {
@@ -393,16 +392,16 @@ export default {
       }
     },
     handleSwipe() /* istanbul ignore next: JSDOM doesn't support touch events */ {
-      const absDeltax = Math.abs(this.touchDeltaX)
-      if (absDeltax <= SWIPE_THRESHOLD) {
+      const absDeltaX = Math.abs(this.touchDeltaX)
+      if (absDeltaX <= SWIPE_THRESHOLD) {
         return
       }
-      const direction = absDeltax / this.touchDeltaX
+      const direction = absDeltaX / this.touchDeltaX
       if (direction > 0) {
-        // swipe left
+        // Swipe left
         this.prev()
       } else if (direction < 0) {
-        // swipe right
+        // Swipe right
         this.next()
       }
     },
@@ -414,7 +413,7 @@ export default {
       }
     },
     touchMove(evt) /* istanbul ignore next: JSDOM doesn't support touch events */ {
-      // ensure swiping with one touch and not pinching
+      // Ensure swiping with one touch and not pinching
       if (evt.touches && evt.touches.length > 1) {
         this.touchDeltaX = 0
       } else {
@@ -439,7 +438,7 @@ export default {
       }
       this._touchTimeout = setTimeout(
         this.start,
-        TOUCHEVENT_COMPAT_WAIT + Math.max(1000, this.interval)
+        TOUCH_EVENT_COMPAT_WAIT + Math.max(1000, this.interval)
       )
     }
   },
@@ -458,7 +457,7 @@ export default {
       [this.$slots.default]
     )
 
-    // Prev and Next Controls
+    // Prev and next controls
     let controls = h(false)
     if (this.controls) {
       controls = [
@@ -567,7 +566,8 @@ export default {
     }
     // Touch support event handlers for environment
     if (!this.noTouch && hasTouchSupport) {
-      /* istanbul ignore next: JSDOM doesn't support touch events */ // Attach appropriate listeners (passsive mode)
+      // Attach appropriate listeners (passive mode)
+      /* istanbul ignore next: JSDOM doesn't support touch events */
       if (hasPointerEvent) {
         on['&pointerdown'] = this.touchStart
         on['&pointerup'] = this.touchEnd
diff --git a/src/utils/noop.js b/src/utils/noop.js
@@ -0,0 +1,3 @@
+const noop = () => {}
+
+export default noop
diff --git a/src/utils/tooltip.class.js b/src/utils/tooltip.class.js

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+const noop = () => {}`
	`2`	`+`
	`3`	`+export default noop`