Skip to content

feat(utils/noop): add noop() util #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2019

Conversation

jacobmllr95
Copy link
Member

Description of Pull Request:

This PR adds a noop() util and uses it wherever possible.
While at it, fix some comments.

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #2892 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2892   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files         197      198    +1     
  Lines        3249     3249           
  Branches      962      962           
=======================================
  Hits         2933     2933           
  Misses        229      229           
  Partials       87       87
Impacted Files Coverage Δ
src/utils/tooltip.class.js 100% <ø> (ø) ⬆️
src/components/carousel/carousel.js 95.96% <100%> (-0.04%) ⬇️
src/utils/noop.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd0708...af3106d. Read the comment docs.

@jacobmllr95 jacobmllr95 requested a review from tmorehouse March 21, 2019 23:48
@jacobmllr95 jacobmllr95 merged commit 61b75dc into bootstrap-vue:dev Mar 21, 2019
@jacobmllr95 jacobmllr95 deleted the fix-noop-util branch March 21, 2019 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants