Skip to content

Alert cannot load b-button-close when imported as an individual component #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mehdirande opened this issue Jan 10, 2018 · 1 comment · Fixed by #1523
Closed

Alert cannot load b-button-close when imported as an individual component #1522

mehdirande opened this issue Jan 10, 2018 · 1 comment · Fixed by #1523

Comments

@mehdirande
Copy link
Contributor

Hi,

When importing only b-alert, if the dismissed prop is set like this:


<template>
  <b-alert :show="true" :dismissible="true">Message</b-alert>
</template>
<script>
  import bAlert from "bootstrap-vue/es/components/alert/alert";
  export default {
    name: 'Dummy',
    components: {
        bAlert
    }
}

An error is throwed :

[Vue warn]: Unknown custom element: - did you register the component correctly? For recursive components, make sure to provide the "name" option.

This is because the button si imported as bBtnClose (from button/button) and used with b-button-close.
mehdirande added a commit to mehdirande/bootstrap-vue that referenced this issue Jan 10, 2018
@mehdirande
Fix bootstrap-vue#1522: Import button-close in alert with a name matc…
b1414f0 
…hing tag.

bButtonClose component was imported in alert with the shortcut alias
(bBtnClose) but used with the full tag (b-button-close). When importing
b-alert as an individual component b-button-close alias was not set and
vue failed to import the b-button-close component.
Importing bButtonClose component with the fullname fix this issue.
@mehdirande mehdirande mentioned this issue Jan 10, 2018
Merged
@pi0 pi0 closed this as completed in #1523 Jan 13, 2018
pi0 pushed a commit that referenced this issue Jan 13, 2018
@mehdirande @pi0
fix(alert): import button-close in alert with a name matching tag. (#…
51b527f 
…1523) fixes #1522.
@pi0
Copy link
Member

pi0 commented Jan 14, 2018

Should be fixed in v1.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1522: Import button-close in alert with a name matching tag. mehdirande/bootstrap-vue
2 participants
@mehdirande @pi0