-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
BV does not follow Vue global name/function plugin convention #3849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The global name being Vue supports both object and function for plugins, and Vue's doc's actually provide examples in the object format: https://vuejs.org/v2/guide/plugins.html#Writing-a-Plugin Object and Function as plugins are acceptable to Vue. so I don't see a need to change from passing Function vs Object as the plugin (an the former actually has benefits when creating the CommonJs bundle version) |
#3850 looks good, thank you |
@Andrei-Pozolotin Note that Vue first inspects the passed plugin as an The BootstrapVue plugin is not a constructor (one doesn't use So to your point number 3, it is not leading to endless confusion (if one understands Vue's internals). |
ok, clear, thank you |
BV exposes itself:
window.bootstrapVue
, not aswindow.BootstrapVue
compare
global.VueRouter = factory()
https://github.com/vuejs/vue-router/blob/dev/dist/vue-router.js#L9
vs
global.bootstrapVue = factory()
https://unpkg.com/browse/bootstrap-vue@2.0.0-rc.27/dist/bootstrap-vue.js
The text was updated successfully, but these errors were encountered: