Skip to content

b-pagination config #4811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AmazingMoon opened this issue Feb 21, 2020 · 3 comments · Fixed by #4810, tghelere/CL#18, mariazevedo88/hash-generator-js#39, mariazevedo88/hash-generator-js#40 or tghelere/CL#20
Closed

b-pagination config #4811

AmazingMoon opened this issue Feb 21, 2020 · 3 comments · Fixed by #4810, tghelere/CL#18, mariazevedo88/hash-generator-js#39, mariazevedo88/hash-generator-js#40 or tghelere/CL#20
Labels
Status: Fixed / Implemented Issue fixed by a new release Type: Feature request

Comments

@AmazingMoon
Copy link

I have a small suggestion, can page-link render into non-a tags?
Provide a configurable property, render as div.page-link, etc.
This is to solve the SEO problem of Link anchor text is trivial.
@tmorehouse
Copy link
Member

tmorehouse commented Feb 21, 2020 •
edited
Loading

Accessibility wise, it would need to stay as an <a> tag for <b-pagination-nav>, but for <b-pagination> we might be able to switch to <button> (it is best to use semantic HTM5 elements where possible to preserve proper roles for a11y rather trying to replicate roles and behaviours on non-interactive elements), assuming that Bootstrap's SCSS/CSS can handle styling the buttons correctly.

Using <a> is Bootstrap v4's recommended structure, but we would be willing to look into switching the <a> for button's in <b-pagination>

@tmorehouse
Copy link
Member

<b-pagination> renders as an ARIA menuitemradio bar (the page numbers have role menuitemradio), so it sounds like the SEO tool you are using doesn't take accessibility into account when looking at the markup.

@AmazingMoon
Copy link
Author

@tmorehouse Yes! So I want to avoid this problem.

This was referenced Feb 21, 2020
Merged
Merged
tmorehouse added a commit that referenced this issue Feb 23, 2020
@tmorehouse @jacobmllr95
feat(b-pagination, b-pagination-nav): improve aria accessibility (closes
7ee4baa 
: #4811, #4160) (#4810)

Co-authored-by: Jacob Müller <jacob.mueller.elz@gmail.com>
This was referenced Mar 27, 2020
Merged
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Apr 7, 2020
Open
This was referenced Apr 15, 2020
Open
Open
@snyk-bot snyk-bot mentioned this issue Apr 30, 2020
Open
@tmorehouse tmorehouse added the Status: Fixed / Implemented Issue fixed by a new release label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Fixed / Implemented Issue fixed by a new release Type: Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(b-pagination, b-pagination-nav): improve aria accessibility (closes: #4811, #4160) bootstrap-vue/bootstrap-vue
[Snyk] Upgrade bootstrap-vue from 2.5.0 to 2.6.0 tghelere/CL
[Snyk] Upgrade bootstrap-vue from 2.5.0 to 2.6.0 mariazevedo88/hash-generator-js
[Snyk] Upgrade bootstrap-vue from 2.6.0 to 2.6.1 mariazevedo88/hash-generator-js
[Snyk] Upgrade bootstrap-vue from 2.6.0 to 2.6.1 tghelere/CL
[Snyk] Upgrade bootstrap-vue from 2.3.0 to 2.7.0 JuroOravec/powerjinja
[Snyk] Upgrade bootstrap-vue from 2.0.0-rc.24 to 2.8.0 mc-ireiser/coreui-free-vue-admin-template
[Snyk] Upgrade bootstrap-vue from 2.0.0-rc.27 to 2.8.0 mc-ireiser/termodaq_app
[Snyk] Upgrade bootstrap-vue from 2.0.0-rc.15 to 2.13.0 leonyork/cognito-oauth2-demo
2 participants
@tmorehouse @AmazingMoon