Skip to content

fix(tooltip): Emit correct $root event name #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

jacobgunnarsson
Copy link
Contributor

I was wondering why this.$root.$emit('bv::hide::tooltip') wasn't working and found this typo.

@codecov-io
Copy link

codecov-io commented Sep 22, 2017

Codecov Report

Merging #1094 into dev will increase coverage by 0.12%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1094      +/-   ##
==========================================
+ Coverage   33.26%   33.39%   +0.12%     
==========================================
  Files         109      109              
  Lines        2850     2857       +7     
  Branches      884      887       +3     
==========================================
+ Hits          948      954       +6     
+ Misses       1531     1529       -2     
- Partials      371      374       +3
Impacted Files Coverage Δ
lib/classes/tooltip.js 4.5% <12.5%> (-0.1%) ⬇️
lib/components/form-input.vue 42.85% <0%> (+3.57%) ⬆️
lib/components/button.js 76.92% <0%> (+3.84%) ⬆️
lib/components/form-group.vue 76.19% <0%> (+4.76%) ⬆️
lib/components/button-group.js 100% <0%> (+33.33%) ⬆️
lib/components/embed.js 100% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51db684...eee95bf. Read the comment docs.

@tmorehouse
Copy link
Member

👍 Thanks for finding this!

Will be available in the next release

@tmorehouse tmorehouse changed the title Fix lib/classes/tooltip.js NAME typo fix:(tooltip): Emit correct $root event name Sep 22, 2017
@tmorehouse tmorehouse added this to the v1.0.0 milestone Sep 22, 2017
@tmorehouse tmorehouse changed the title fix:(tooltip): Emit correct $root event name fix(tooltip): Emit correct $root event name Sep 22, 2017
@tmorehouse tmorehouse merged commit 87e5eb2 into bootstrap-vue:dev Sep 22, 2017
@tmorehouse tmorehouse mentioned this pull request Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants