fix(Progress): Bootstrap V4.beta.2 CSS height prop change #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move height prop from progress-bar to progress according to current Bootstrap4-beta2. fixes #1216
Codecov Report
@@ Coverage Diff @@
## dev #1217 +/- ##
==========================================
+ Coverage 32.86% 32.87% +0.01%
==========================================
Files 109 109
Lines 2866 2865 -1
Branches 920 890 -30
==========================================
Hits 942 942
+ Misses 1547 1546 -1
Partials 377 377
Continue to review full report at Codecov.
|
|
Will need to adjust b-progress-bar as it also sets it's own height based on parent b-progress height value. Basically just need to remove it as new CSS sets height === 100% on the progress-bar |
56 tasks
tmorehouse
approved these changes
Oct 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move height prop from progress-bar to progress according to current Bootstrap4-beta2.
fixes #1216