Skip to content

[Tabs component] updates #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2017
Merged

[Tabs component] updates #124

merged 2 commits into from
Mar 2, 2017

Conversation

dleesalestreamsoft
Copy link
Contributor

made the tabs be able to be set using :value and it will emit a input that can be used for vuex and vue-router

@pi0
Copy link
Member

pi0 commented Mar 1, 2017

@dleesalestreamsoft Really thanks :) Just please fix linter errors (npm run fix will fix most of them).

@dleesalestreamsoft
Copy link
Contributor Author

@pi0 when i tried running xo --fix i got so many lint errors that it is complaining about. not even in just the tabs/tab file. so I am guessing you something is different about the configuration of xo.

@pi0
Copy link
Member

pi0 commented Mar 2, 2017

@dleesalestreamsoft ok :) i'll fix them later

@pi0 pi0 merged commit 95d97db into bootstrap-vue:master Mar 2, 2017
pi0 pushed a commit that referenced this pull request Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants