Skip to content

do not trigger on key events when modal is not visible #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2017
Merged

do not trigger on key events when modal is not visible #133

merged 1 commit into from
Mar 6, 2017

Conversation

Magnum5234
Copy link
Contributor

When modal is not shown the ESC keypress does the following:

bootstrap-vue.common.js:1 Uncaught TypeError: Cannot read property 'classList' of undefined
    at bootstrap-vue.common.js:1
(anonymous) @ bootstrap-vue.common.js:1

@pi0 pi0 merged commit d409e53 into bootstrap-vue:master Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Magnum5234 @pi0