Skip to content

Improve and document b-nav-item-dropdown #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2017
Merged

Improve and document b-nav-item-dropdown #141

merged 1 commit into from
Mar 13, 2017

Conversation

polmuz
Copy link
Contributor

@polmuz polmuz commented Mar 12, 2017

  • Change open class from open to show to match latest
    boostrap version
  • Use text prop if provided in the main slot
  • Add documentation in the navbar section
  • Try to improve markup indentation

@polmuz
Improve and document b-nav-item-dropdown
c326f2e 
- Change open class from `open` to `show` to match latest
  boostrap version
- Use text prop if provided in the main slot
- Add documentation in the navbar section
- Try to improve markup indentation
@polmuz
Copy link
Contributor Author

polmuz commented Mar 12, 2017

This may affect #122

@pi0
Copy link
Member

pi0 commented Mar 13, 2017

@polmuz Nice. Thanks for your contribution :)

@pi0 pi0 merged commit db7c01f into bootstrap-vue:master Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polmuz @pi0