Update modal.vue #142
Merged
Update modal.vue #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add .bind(this) to hub.$on event listeners because without this modification at the moment of receving event "this" points to root element instead of current.
pi0
reviewed
Mar 13, 2017
| @@ -110,8 +110,8 @@ export default { | |||
| }, | |||
| created() { | |||
| const hub = this.$root; | |||
There was a problem hiding this comment.
Maybe we can use self trick :)) Something like this:
const self=this;
hub.$on('show::modal', id => id === self.id && self.show());
``There was a problem hiding this comment.
but it's the same as usind .bind(this) and with extra var
Methods taken from standalone dropdown component to add clickout-hide action.
|
@mosinve Thanks for your contribution :) please say when your work was done on this component and i will merge it soon :) |
|
It' works now) at least at this point))) so you can merge ) |
pi0
approved these changes
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add .bind(this) to hub.$on event listeners because without this modification at the moment of receving event "this" points to root element instead of current.
If I'm wrong, tell me how to use modal without his mod, pls :)