Skip to content

Feat/checkbox & radio #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2018
Merged

Feat/checkbox & radio #1539

merged 2 commits into from
Jan 23, 2018

Conversation

johnrazeur
Copy link
Contributor

Add the missing attribute "for" to the checkbox.
Update the HTML markup and class of the radio form element to the new html structure of bootstrap beta-3.

#1408

@codecov
Copy link

codecov bot commented Jan 16, 2018

Codecov Report

Merging #1539 into feat/beta-3 will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           feat/beta-3    #1539      +/-   ##
===============================================
- Coverage        53.75%   53.69%   -0.07%     
===============================================
  Files              134      134              
  Lines             2186     2181       -5     
  Branches           697      696       -1     
===============================================
- Hits              1175     1171       -4     
+ Misses             720      719       -1     
  Partials           291      291
Impacted Files Coverage Δ
src/components/form-checkbox/form-checkbox.js 33.33% <ø> (ø) ⬆️
src/components/form-radio/form-radio.js 33.33% <100%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f65efb...a57fbb1. Read the comment docs.

@pi0 pi0 merged commit ccfb5b1 into bootstrap-vue:feat/beta-3 Jan 23, 2018
@pi0
Copy link
Member

pi0 commented Jan 23, 2018

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants