fix(Table) allow empty labels #1587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1587 +/- ##
=======================================
Coverage 59.96% 59.96%
=======================================
Files 153 153
Lines 2850 2850
Branches 782 782
=======================================
Hits 1709 1709
Misses 821 821
Partials 320 320
Continue to review full report at Codecov.
|
|
Note this can break ARIA compliance when a column doesn't have a header or an aria label for blind users, as they cannot see the visual context of the column, they need a label. The field's key should be used as the aria-label on the |
tmorehouse
added a commit
that referenced
this pull request
Nov 10, 2018
When the fields's label was set to a blank string, this left non-sighted users at a disadvantage as to what the column is about. This adds the field's key (humanized) to the `aria-label` to provides hint to non-sighted users. Alternatively if a field title is provided, then the aria-label is not altered. Addresses ARIA issues introduced by PR #1587
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1582