Skip to content

replace lorempixel.com with picsum.photos, resolves #1823 #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2018
Merged

replace lorempixel.com with picsum.photos, resolves #1823 #1825

merged 2 commits into from
May 15, 2018

Conversation

rinick
Copy link
Contributor

@rinick rinick commented May 13, 2018

lorempixel.com is down, replace them with placeimg.com

@codecov
Copy link

codecov bot commented May 13, 2018

Codecov Report

Merging #1825 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1825   +/-   ##
=======================================
  Coverage   61.04%   61.04%           
=======================================
  Files         154      154           
  Lines        2862     2862           
  Branches      791      791           
=======================================
  Hits         1747     1747           
  Misses        800      800           
  Partials      315      315

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a35374...a5b88c4. Read the comment docs.

@emanuelmutschlechner
Copy link
Contributor

placeimg.com does not have the same categories, and serves random images instead.

And the second and more important thing I noticed is, it serves random images all the time. I would go with picsum.photos and pick specific images from their list.

@rinick rinick changed the title replace lorempixel.com with placeimg.com, resolves #1823 replace lorempixel.com with picsum.photos, resolves #1823 May 13, 2018
Copy link
Contributor

@emanuelmutschlechner emanuelmutschlechner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@mosinve mosinve merged commit e4ad499 into bootstrap-vue:dev May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants