fix(table): Fix Table aria-rowcount #1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1836 +/- ##
=======================================
Coverage 61.04% 61.04%
=======================================
Files 154 154
Lines 2862 2862
Branches 791 791
=======================================
Hits 1747 1747
Misses 800 800
Partials 315 315
Continue to review full report at Codecov.
|
tmorehouse
reviewed
Nov 10, 2018
| ? '-1' | ||
| : null | ||
| 'aria-rowcount': this.$attrs['aria-rowcount'] || | ||
| this.items.length > this.perPage ? this.items.length : null |
There was a problem hiding this comment.
This assumes that this.items is an array. It isn't when it is a provider function. When a provider, this.items.length actually returns the argument count the provider function is expecting (i.e. 1 or 2).
PR #2149 fixes this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the table component uses this code to set the
aria-rowcountproperty:According to the WAI-ARIA spec,
aria-rowcountshould only be set to -1 if the total number of rows is unknown. The current code has -1 set as the default for any paged tables.Furthermore, if all of items are currently displayed on the table, we do not need to set
aria-rowcountas accessibility readers will automatically count these.I propose the following code change: