fix(readonly): allow readonly to be forced to false when plaintext is enabled #1841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1841 +/- ##
=======================================
Coverage 60.85% 60.85%
=======================================
Files 154 154
Lines 2879 2879
Branches 798 798
=======================================
Hits 1752 1752
Misses 808 808
Partials 319 319
Continue to review full report at Codecov.
|
|
Actually plaintext is supposed to be a readonly input per Bootstrap V4 docs (it is meant to display a form control that is read only, but without the grey background., making it looks more like text. It would be better to define override styles to override form-control using an extra class on the input (as per Bootstrap V4 custom styles ability) |
tmorehouse
added a commit
that referenced
this pull request
Nov 14, 2018
reverts changes from #1841, as it breaks the readonly plaintext requirements (plus documentatijn was not properly updated to reflect changes)
tmorehouse
added a commit
that referenced
this pull request
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plaintext could be convenient to customize
b-inputstyling (for example when you need to wrap it into a div), but readonly is currently forced to true, when plaintext is enabled.this PR introduces an indeterminate state for readonly, and hence allows it to be forced to false even with plaintext enabled.