Skip to content

Added vee-validate example #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2018
Merged

Added vee-validate example #1889

merged 2 commits into from
Jun 16, 2018

Conversation

toadkicker
Copy link
Contributor

Added example for vee-validate and fixed example for vuelidate state property

Added example for vee-validate and fixed example for vuelidate state property
@codecov
Copy link

codecov bot commented Jun 14, 2018

Codecov Report

Merging #1889 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #1889   +/-   ##
=====================================
  Coverage   61.2%   61.2%           
=====================================
  Files        154     154           
  Lines       2882    2882           
  Branches     797     797           
=====================================
  Hits        1764    1764           
  Misses       802     802           
  Partials     316     316

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2970509...607ee86. Read the comment docs.

@toadkicker
Copy link
Contributor Author

toadkicker commented Jun 14, 2018

Of note I'm excluding the steps on the application setup of vee-validate because I felt it was better to leave that with them. I hope that is clear for the example as the vuelidate one skips those steps as well.

<b-form-select id="exampleInput2"
:options="foods"
v-validate="{required: true}"
:state="validateState('form.foods')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where this method from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing. I wrote it, but it didn't end up in the patch. I've updated the doc to include it.

</b-form-group>
<b-button type="submit"
variant="primary"
:disabled="$v.form.$invalid">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$v is Vuelidate related, so here must be vee-validate form state check

@mosinve mosinve merged commit b2fedf1 into bootstrap-vue:dev Jun 16, 2018
@toadkicker toadkicker deleted the patch-1 branch June 16, 2018 11:12
@tmorehouse tmorehouse mentioned this pull request Nov 14, 2018
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants