feat(table): Split computedItems into multiple functions #1893
Conversation
Don't do all the processing in one function so external users (parent) can
grab the items at various stages without having to reproduce all the
filtering/sorting/pagination logic.
For example a parent may want to have access to the filtered and sorted,
but not yet paginated set of items. With the split functions it can now
do something like this:
const table = this.$refs.the-table
let items = table.hasProvider ? table.localItems : table.items
items = table.sortItems(table.filterItems(items))
This patch incorporates no functional changes.
e0d6a5f to
05c0915
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1893 +/- ##
=========================================
+ Coverage 61.2% 61.23% +0.02%
=========================================
Files 154 154
Lines 2882 2884 +2
Branches 797 796 -1
=========================================
+ Hits 1764 1766 +2
Misses 802 802
Partials 316 316
Continue to review full report at Codecov.
|
Refactor `filterItems` method
|
This change actually broke efficient reactivity, since the computed prop getters were moved from a computed prop into non reactive methods.. slowing down rendering on larger tables. External functions/addons should not be dipping into unpublished methods or computed props. Event interfaces or oneway-syncable props should be used instead. PR #2149 fixes the broken reactivity by making sure the props/data that need to be reacted on are inside computed props (i.e to register that they are dependent upon them. Moving to methods broke that). |
To make it easier to extend the functionality of b-table without feature creep in the b-table itself, a bit more/easier access to the various stages of computedItems is needed.
For example, to implement #225 externally, access is needed to the filtered and sorted, but not yet paginated items. With this change this becomes possible by doing something like this:
const table = this.$refs.the-table
let items = table.hasProvider ? table.localItems : table.items
items = table.sortItems(table.filterItems(items))
This PR incorporates no functional changes and adds no features.