Skip to content

feat (pagination) added slots for first, prev, next, last, and ellipsis #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Oct 13, 2018
Merged

feat (pagination) added slots for first, prev, next, last, and ellipsis #1980

merged 1 commit into from Oct 13, 2018

Conversation

toadkicker
Copy link
Contributor

Fixed #1870.

@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #1980 into dev will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1980      +/-   ##
==========================================
- Coverage   61.27%   61.23%   -0.05%     
==========================================
  Files         154      154              
  Lines        2887     2884       -3     
  Branches      796      797       +1     
==========================================
- Hits         1769     1766       -3     
  Misses        802      802              
  Partials      316      316
Impacted Files Coverage Δ
src/mixins/pagination.js 58.87% <100%> (ø) ⬆️
src/components/button/button.js 76% <0%> (-0.93%) ⬇️
src/components/modal/modal.js 23.47% <0%> (-0.36%) ⬇️
src/components/table/table.js 76.38% <0%> (-0.08%) ⬇️
src/components/dropdown/dropdown.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update becaa98...ac0410b. Read the comment docs.

@toadkicker toadkicker changed the title pagination (feat) added slots for first, prev, next, last, and ellipsis feat (pagination) added slots for first, prev, next, last, and ellipsis Aug 14, 2018
@mosinve mosinve merged commit 1b7e7de into bootstrap-vue:dev Oct 13, 2018
shinrox added a commit to shinrox/bootstrap-vue that referenced this pull request Oct 26, 2018
* dev: (31 commits)
  feat(card): support left and right image placement (bootstrap-vue#1981)
  fix(collapse/toggle): "collapsed" class cleared when component updated (bootstrap-vue#2102)
  fix(form-file): Add validation of single file (bootstrap-vue#2028)
  chore(docs): minor update to the b-form-input docs
  chore(docs): Minor update to b-form-input docs
  feat(table): Add row-unhovered event (bootstrap-vue#1874)
  feat(table): Support contextmenu event binding for table rows (bootstrap-vue#2064)
  docs(table): fix minor typo (bootstrap-vue#2093)
  feat(table): Support sorting on nested object properties (bootstrap-vue#1868)
  perf(modal): optimize model.resetScrollbar, resolves bootstrap-vue#1831  (bootstrap-vue#1837)
  docs: Update images reference section (bootstrap-vue#1999)
  fix(observe-dom): fix comment typo (bootstrap-vue#2084)
  chore(modal): trivial word fix in comment (bootstrap-vue#2089)
  (docs): Fix grammer in Intro readme (bootstrap-vue#2092)
  fix(modal): prevent scrolling on .modal-content focus, fixes bootstrap-vue#1748 (bootstrap-vue#2060)
  feat(pagination):  added slots for first, prev, next, last, and ellipsis. Fixes bootstrap-vue#1870. (bootstrap-vue#1980)
  Handle state change on validated fields. (bootstrap-vue#1984)
  fix(docs): input group prepend slot typo (bootstrap-vue#2059)
  fix(dependencies): replace opencollective with opencollective-postintall (bootstrap-vue#2067)
  fix(docs): change b-input-group attribute 'left' to 'prepend' (bootstrap-vue#2017)
  ...
@tmorehouse
Copy link
Member

@toadkicker would yo be able to update the /components/pagination/package.json and /components/pagination-nav/package.json to add in the slot definitions? The package.json file is used to create the component reference section at the bottom of the docs page (documenting events and slots) You can check out the package.json in other components for exampled on how to document the slots

@toadkicker
Copy link
Contributor Author

toadkicker commented Nov 10, 2018

@tmorehouse PR inbound for that..what branch should I target?

@tmorehouse
Copy link
Member

@toadkicker dev branch would be great!

Thanks!

@tmorehouse
Copy link
Member

Oh, and could you add the documentation about the slots into pagination-nav README.md as well? pagination-nav uses the same render mixin as pagination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants