Codecov Report

Merging #2008 into dev will increase coverage by 0.11%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##              dev    #2008      +/-   ##
==========================================
+ Coverage   64.61%   64.72%   +0.11%     
==========================================
  Files         154      154              
  Lines        2922     2917       -5     
  Branches      805      803       -2     
==========================================
  Hits         1888     1888              
+ Misses        744      741       -3     
+ Partials      290      288       -2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29b563a...dae59da. Read the comment docs.

I propose we use the mime-types package and simplify this a lot for developers. It would be really nice to just say accepts="images", accepts="video", etc. and not worry about the specifics of all the mime types that means. We would also prevent a possible content spoofing attack because it can trust that the JS API is comparing the same symbols.

@toadkicker there is already images/* simple enough I guess. I see what you saying about spoofing I'll see how it can be done.

Basically, we should fall back to letting the browser handle the accept formats.

Older browsers had issues with which format to use (i.e. extension vs IANA media types).

Until we make a matching algorithm to test the file type (parsing the accept string into RegEx's and then testing against the file.type for IANA or file.name for extensions), we should just let the browser do the validation