feat(table): Support contextmenu event binding for table rows #2064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2064 +/- ##
==========================================
- Coverage 64.76% 61.29% -3.47%
==========================================
Files 154 154
Lines 2903 2891 -12
Branches 799 797 -2
==========================================
- Hits 1880 1772 -108
- Misses 735 803 +68
- Partials 288 316 +28
Continue to review full report at Codecov.
|
peterjosling
pushed a commit
to peterjosling/apple-music-webplayer
that referenced
this pull request
Oct 8, 2018
Easier to hit than a small click target on the right. Ideally it would pop up at the click position, but I'm having trouble getting Bootstrap Vue to do what I want. This is an improvement for now. Had to hack it a bit to store the ID of the song in the DOM, on each TD element. I've filed a pull request to add contextmenu event support to the table component natively (bootstrap-vue/bootstrap-vue#2064), but this is the only way I could think to do it for now.
zachomedia
pushed a commit
to zachomedia/apple-music-webplayer
that referenced
this pull request
Oct 12, 2018
Easier to hit than a small click target on the right. Ideally it would pop up at the click position, but I'm having trouble getting Bootstrap Vue to do what I want. This is an improvement for now. Had to hack it a bit to store the ID of the song in the DOM, on each TD element. I've filed a pull request to add contextmenu event support to the table component natively (bootstrap-vue/bootstrap-vue#2064), but this is the only way I could think to do it for now.
|
Would love to see this get merged! |
|
I think the event name should be |
Allows for right click as well as existing click + double click.
f605edd to
d14e5ba
Compare
|
Good thinking. I've renamed it to TIL: the browser event is |
tmorehouse
approved these changes
Oct 23, 2018
shinrox
added a commit
to shinrox/bootstrap-vue
that referenced
this pull request
Oct 26, 2018
* dev: (31 commits) feat(card): support left and right image placement (bootstrap-vue#1981) fix(collapse/toggle): "collapsed" class cleared when component updated (bootstrap-vue#2102) fix(form-file): Add validation of single file (bootstrap-vue#2028) chore(docs): minor update to the b-form-input docs chore(docs): Minor update to b-form-input docs feat(table): Add row-unhovered event (bootstrap-vue#1874) feat(table): Support contextmenu event binding for table rows (bootstrap-vue#2064) docs(table): fix minor typo (bootstrap-vue#2093) feat(table): Support sorting on nested object properties (bootstrap-vue#1868) perf(modal): optimize model.resetScrollbar, resolves bootstrap-vue#1831 (bootstrap-vue#1837) docs: Update images reference section (bootstrap-vue#1999) fix(observe-dom): fix comment typo (bootstrap-vue#2084) chore(modal): trivial word fix in comment (bootstrap-vue#2089) (docs): Fix grammer in Intro readme (bootstrap-vue#2092) fix(modal): prevent scrolling on .modal-content focus, fixes bootstrap-vue#1748 (bootstrap-vue#2060) feat(pagination): added slots for first, prev, next, last, and ellipsis. Fixes bootstrap-vue#1870. (bootstrap-vue#1980) Handle state change on validated fields. (bootstrap-vue#1984) fix(docs): input group prepend slot typo (bootstrap-vue#2059) fix(dependencies): replace opencollective with opencollective-postintall (bootstrap-vue#2067) fix(docs): change b-input-group attribute 'left' to 'prepend' (bootstrap-vue#2017) ...
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for right click as well as existing click + double click.