Skip to content

fix(collapse/toggle): "collapsed" class cleared when component updated. fixes #1798 #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2018
Merged

fix(collapse/toggle): "collapsed" class cleared when component updated. fixes #1798 #2102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
144b8f1
fix(collapse/toggle): "collapsed" class cleared when component updated
lianee Oct 25, 2018
bbde109
Update collapse.js
lianee Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/collapse/collapse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ export default {
}
this.emitState()
},
updated () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually runs when the component's vdom has updated, and doesn't monitor for changes outside of the component.

What might be a better approach to this, is to update the v-b-toggle directive to use the observeDom utility to monitor changes to the trigger element's attributes (shallow observer).

I will look into this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although just testing in the playground, this appears to work for most cases.

this.$root.$emit(EVENT_STATE, this.id, this.show)
},
beforeDestroy () {
if (this.isNav && typeof document !== 'undefined') {
window.removeEventListener('resize', this.handleResize, false)
Expand Down