-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(form-textarea): Bug fixes and features #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2111 +/- ##
==========================================
+ Coverage 66.09% 66.51% +0.42%
==========================================
Files 158 159 +1
Lines 3017 3058 +41
Branches 840 852 +12
==========================================
+ Hits 1994 2034 +40
- Misses 741 744 +3
+ Partials 282 280 -2
Continue to review full report at Codecov.
|
Also imported all native event listeners
Document events
For use with b-form-textarea and b-form-input
Move common b-form-textarea/b-form-input data, props, computed, methods, watchers and lifecycle hooks to mixin
Migrate common props/data/methods/computed/hooks to mixin
…n blur event this will most li key cause the test to fail, as they will need updating
When is this fix released? In version 2.0.0-rc.11 the problem still exists to my experience. |
+1 I'm still experiencing this issue. |
@yujianancy please open a new issue. |
Fixes and improvements to
b-form-textbox
trim
andnumber
props to emulate v-model modifiers.trim
and.number
update
)<textarea>
element<b-form-textarea>
and<b-form-input>
to mixin to minimize codebasevue-test-utils
trim
andnumber
modifier propsauto rows/heightcannot testgetComputedStyle
in JSDOM test environmentFixes #1708
Closes #1710
Fixes #1915
Fixes #1470
To-Do:
b-form-input
use the new mixin, and to follow the new event model via separate PR