feat(security): Strip HTML script tags before inserting content into DOM. Fixes #1974,#1665 #2134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utility for removing script tags from injected HTML (i.e. for use with v-html or domProps.innerHTML) Prevents user supplied input form injecting scripts into the DOM
Remove validator of size prop... to allow for custom CSS defined sizes
Codecov Report
@@ Coverage Diff @@
## dev #2134 +/- ##
=======================================
Coverage 64.97% 64.97%
=======================================
Files 158 159 +1
Lines 2958 2958
Branches 811 811
=======================================
Hits 1922 1922
Misses 749 749
Partials 287 287
Continue to review full report at Codecov.
|
89 tasks
pi0
pushed a commit
that referenced
this pull request
Jan 20, 2019
…DOM. Fixes #1974,#1665 (#2134) * fixed a typo (#1931) * Create utils/strip-sripts.js Utility for removing script tags from injected HTML (i.e. for use with v-html or domProps.innerHTML) Prevents user supplied input form injecting scripts into the DOM * mixins/form-options.js use new striptScripts util * Update button-group.js Remove validator of size prop... to allow for custom CSS defined sizes * Update card-body.js * Update dropdown.js * Update form-group.js * Update input-group.js * Update jumbotron.js * Update modal.js * Update nav-item-dropdown.js * Update progress-bar.js * Update table.js * pagination mixin: add stripScripts and remove temporary button styling * Minor update to table readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR:
Utility for removing script tags from injected HTML (i.e. for use with
v-htmlordomProps.innerHTML)Prevents possible user supplied input form injecting scripts into the DOM
Fixes #1974
Fixes #1665
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
Scripts will no longer be injected into the DOM (i.e. from user supplied data or component props that support HTML)
The PR fulfills these requirements:
devbranch, not themasterbranchfixes #xxxx[,#xxxx], where "xxxx" is the issue number)If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's description includes:
PR titles should following the Conventional Commits naming convention