Skip to content

fix(safeId): trigger id creation/update after mount (fixes #1978) #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 12, 2018

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Nov 12, 2018

Description of Pull Request:

safe ID's must be created on mount() of the component, and only client side. This was the original way it was intended, but was inadvertently changed over time to lose its reactive nature (there is no reactivity to this._uid)

this addresses this issue by storing the bv safe ID in data on mount, of which computed properties and methods can rely on it.

The computed prop safeId replaces the method safeId(...), and returns a cached method reference which mimics the old method safeId(...), and accepts the same optional suffix parameter.

fixes #1978

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #2161 into dev will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #2161      +/-   ##
=========================================
+ Coverage   65.4%   65.46%   +0.06%     
=========================================
  Files        159      159              
  Lines       3000     3003       +3     
  Branches     834      834              
=========================================
+ Hits        1962     1966       +4     
+ Misses       751      750       -1     
  Partials     287      287
Impacted Files Coverage Δ
src/mixins/id.js 100% <100%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f716cc9...f0c3a92. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(id): trigger id update on mount (fixes #1978) fix(id): trigger id creation/update on mount (fixes #1978) Nov 12, 2018
@tmorehouse tmorehouse changed the title fix(id): trigger id creation/update on mount (fixes #1978) fix(safeId): trigger id creation/update after mount (fixes #1978) Nov 12, 2018
@tmorehouse tmorehouse merged commit 48218fe into dev Nov 12, 2018
@tmorehouse tmorehouse deleted the tmorehouse/safeid branch November 12, 2018 19:20
@tmorehouse
Copy link
Member Author

Also fixes #1820

@tmorehouse tmorehouse mentioned this pull request Nov 14, 2018
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

b-checkbox label's for not working in SSR mode
1 participant