Skip to content

fix(docs): fix playground issues. fixes #1843 #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 82 commits into from
Nov 16, 2018
Merged

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Nov 14, 2018

Description of Pull Request:

Fix playground hang issues when invalid template or us is entered. only update stored copy of playground javascript and template if compilation successful.

Playground edits will be reset to default if last visit to playground was more than 7 days from last edit.

Now supports using render functions as alternative to template html.

Fixes #1843

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #2177 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2177   +/-   ##
=======================================
  Coverage   65.94%   65.94%           
=======================================
  Files         158      158           
  Lines        3004     3004           
  Branches      836      836           
=======================================
  Hits         1981     1981           
  Misses        741      741           
  Partials      282      282

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aacc7c0...ffee5b8. Read the comment docs.

@tmorehouse tmorehouse changed the title docs(playground): fix playground issues. fixes #1843 fix(docs): fix playground issues. fixes #1843 Nov 14, 2018
@tmorehouse
Copy link
Member Author

still has an infinite loop on render when template references a variable that is not defined... not sure where that happens...

@tmorehouse tmorehouse merged commit 5bdc2e6 into dev Nov 16, 2018
@tmorehouse tmorehouse deleted the tmorehouse/playground branch November 16, 2018 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BootstrapVue Playground Crash
1 participant