-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(docs): fix playground issues. fixes #1843 #2177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2177 +/- ##
=======================================
Coverage 65.94% 65.94%
=======================================
Files 158 158
Lines 3004 3004
Branches 836 836
=======================================
Hits 1981 1981
Misses 741 741
Partials 282 282 Continue to review full report at Codecov.
|
still has an infinite loop on render when template references a variable that is not defined... not sure where that happens... |
Minor updates
Description of Pull Request:
Fix playground hang issues when invalid template or us is entered. only update stored copy of playground javascript and template if compilation successful.
Playground edits will be reset to default if last visit to playground was more than 7 days from last edit.
Now supports using render functions as alternative to template html.
Fixes #1843
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)CHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes: