Skip to content

fix(list-group-item): set button type to 'button' when button in mode or tag=button (Fixes #2192) #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 18, 2018

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Nov 18, 2018

Description of Pull Request:

A <button> element without a type specified defaults to type "submit" in some browsers.

This PR explicitly sets the attribute type="button" when <b-list-group-item> is rendering a <button> element, and no type attribute is supplied.

Fixes #2192

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Nov 18, 2018

Codecov Report

Merging #2194 into dev will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2194      +/-   ##
==========================================
+ Coverage   65.94%   66.03%   +0.09%     
==========================================
  Files         158      158              
  Lines        3004     3012       +8     
  Branches      836      839       +3     
==========================================
+ Hits         1981     1989       +8     
  Misses        741      741              
  Partials      282      282
Impacted Files Coverage Δ
src/components/list-group/list-group-item.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e167688...3d79342. Read the comment docs.

@tmorehouse tmorehouse merged commit 4322ccb into dev Nov 18, 2018
@tmorehouse tmorehouse deleted the tmorehouse/list-group-item branch November 18, 2018 03:41
@tmorehouse tmorehouse mentioned this pull request Nov 18, 2018
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[b-list-group-item] Button list group item defaults to "submit" type
1 participant