Skip to content

feat(table): Add table-busy slot for loading status. Closes #1859 #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 19, 2018

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Nov 18, 2018

Description of Pull Request:

Adds a new slot table-busy which allows users to display a loading message when the table is in the busy state.

If no table-busy slot is present, the current rows are displayed (as was the behaviour before)

Includes new test suite for busy state testing using vue-test-utils

Closes #1859

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

Adds a new slot `table-busy` which allows users to display a loading message when the table is in the busy state.

If no `table-busy` slot is present, the current rows are displayed (as was the behaviour before)

Closes #1859
@codecov
Copy link

codecov bot commented Nov 18, 2018

Codecov Report

Merging #2196 into dev will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2196      +/-   ##
==========================================
+ Coverage   66.04%   66.09%   +0.04%     
==========================================
  Files         158      158              
  Lines        3013     3017       +4     
  Branches      839      840       +1     
==========================================
+ Hits         1990     1994       +4     
  Misses        741      741              
  Partials      282      282
Impacted Files Coverage Δ
src/components/table/table.js 76.15% <66.66%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0cdca0...d4117b9. Read the comment docs.

@tmorehouse tmorehouse requested review from mosinve and pi0 November 18, 2018 23:13
@tmorehouse tmorehouse changed the title feat(table): Add table-busy slot for loading status. Fixes #1859 feat(table): Add table-busy slot for loading status. Closes #1859 Nov 18, 2018
@tmorehouse tmorehouse mentioned this pull request Nov 19, 2018
89 tasks
@tmorehouse tmorehouse merged commit a654a61 into dev Nov 19, 2018
@tmorehouse tmorehouse deleted the tmorehouse/table-busy branch November 19, 2018 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show loading message for b-table.
1 participant