-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(table): Add table-busy slot for loading status. Closes #1859 #2196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new slot `table-busy` which allows users to display a loading message when the table is in the busy state. If no `table-busy` slot is present, the current rows are displayed (as was the behaviour before) Closes #1859
Codecov Report
@@ Coverage Diff @@
## dev #2196 +/- ##
==========================================
+ Coverage 66.04% 66.09% +0.04%
==========================================
Files 158 158
Lines 3013 3017 +4
Branches 839 840 +1
==========================================
+ Hits 1990 1994 +4
Misses 741 741
Partials 282 282
Continue to review full report at Codecov.
|
Add provider function busy testing
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request:
Adds a new slot
table-busy
which allows users to display a loading message when the table is in the busy state.If no
table-busy
slot is present, the current rows are displayed (as was the behaviour before)Includes new test suite for
busy
state testing usingvue-test-utils
Closes #1859
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)CHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)