Skip to content

fix(select): Current v-model value on change event (fixes #1772) #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2018

Conversation

majakudlicka
Copy link
Contributor

@majakudlicka majakudlicka commented Nov 22, 2018

Description of Pull Request:

This PR is to ensure that current value of v-model is present on change event. Please see details of the issue for more detailed description (#1772).

Fixes #1772

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #2207 into dev will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2207      +/-   ##
==========================================
- Coverage   66.26%   66.23%   -0.03%     
==========================================
  Files         159      159              
  Lines        3035     3036       +1     
  Branches      842      842              
==========================================
  Hits         2011     2011              
- Misses        744      745       +1     
  Partials      280      280
Impacted Files Coverage Δ
src/components/form-select/form-select.js 57.89% <0%> (-3.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c9936e...5a55eab. Read the comment docs.

@majakudlicka majakudlicka reopened this Nov 22, 2018
@tmorehouse tmorehouse merged commit 7a860ee into bootstrap-vue:dev Nov 22, 2018
@tmorehouse
Copy link
Member

thanks!

@tmorehouse tmorehouse mentioned this pull request Nov 22, 2018
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting old v-model object value after @change event in b-form-select
2 participants