Skip to content

fix(collapse): when is-nav, better checking of click events (Fixes #2222) #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 26, 2018

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Nov 26, 2018

Description of Pull Request:

In some cases, inside a b-collapse in is-nav mode, when the nav-item has sub elements/markup, the click event was not being detected by b-collapse to trigger the collapse.

Fixes #2222

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Nov 26, 2018

Codecov Report

Merging #2225 into dev will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #2225   +/-   ##
====================================
  Coverage    66%     66%           
====================================
  Files       158     158           
  Lines      3062    3062           
  Branches    846     846           
====================================
  Hits       2021    2021           
  Misses      760     760           
  Partials    281     281
Impacted Files Coverage Δ
src/components/collapse/collapse.js 75.4% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c387751...efcad86. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(nav-item): move listeners to b-link sub component (Fixes #2222) fix(collapse): when is-nav, better checking of click events (Fixes #2222) Nov 26, 2018
@tmorehouse tmorehouse merged commit 8b96e1e into dev Nov 26, 2018
@tmorehouse tmorehouse deleted the tmorehouse/nav-item branch November 26, 2018 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<b-collapse> doesn't collapse when <b-nav-item> contains elements
1 participant