-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(dropdown): Menu focusout close handling #2252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown): Menu focusout close handling #2252
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2252 +/- ##
==========================================
- Coverage 65.98% 65.61% -0.37%
==========================================
Files 158 160 +2
Lines 3063 3100 +37
Branches 846 859 +13
==========================================
+ Hits 2021 2034 +13
- Misses 761 778 +17
- Partials 281 288 +7
Continue to review full report at Codecov.
|
This reverts commit 3d1447b.
@jackmu95 So just to make sure I'm on the same page, this issue is with adding a |
Yes exactly. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@tmorehouse I'am happy with this now. Can you please review this again? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Looks good.. any other tweaks you need before merging? |
I'am done here and really happy with what we came up here. |
Thanks for the great work! |
Description of Pull Request:
This is a follow-up PR to #2251 and addresses the real issue for
.dropdown-menu
'sfocusout
handling.PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)CHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes: