Skip to content

fix(table): Emit v-model input event only when computedItems changes (closes #2231) #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2018

Conversation

tmorehouse
Copy link
Member

Description of Pull Request:

Rather than updating the v-model on every render, emit only when the displayed row data changes.

Closes #2231

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

… changes (closes #2231)

Rather than updating the v-model on every render, emit only when the displayed row data changes.

Closes #2231
@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #2254 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2254   +/-   ##
=======================================
  Coverage   67.48%   67.48%           
=======================================
  Files         160      160           
  Lines        3060     3060           
  Branches      841      841           
=======================================
  Hits         2065     2065           
  Misses        732      732           
  Partials      263      263
Impacted Files Coverage Δ
src/components/table/table.js 74.63% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a68d5...15cd46a. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(table): Emit v-model update (input) event only when computedItems changes (closes #2231) fix(table): Emit v-model input event only when computedItems changes (closes #2231) Dec 8, 2018
@tmorehouse tmorehouse mentioned this pull request Dec 8, 2018
89 tasks
@tmorehouse tmorehouse merged commit f0fb9af into dev Dec 8, 2018
@tmorehouse tmorehouse deleted the tmorehouse/table-v-model branch December 8, 2018 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[b-table] unexpected input event triggered by reactive data used in triggered method
1 participant