-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(docs): use babel-standalone in playground/v-play to support IE #2286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2286 +/- ##
=======================================
Coverage 66.55% 66.55%
=======================================
Files 162 162
Lines 3169 3169
Branches 879 879
=======================================
Hits 2109 2109
Misses 779 779
Partials 281 281 Continue to review full report at Codecov.
|
babel-standalone is imported lazily, which can make the first docs page shown with v-play to have a slight delay before the live examples are shown. Once loaded, switch pages is fast. |
Includes a few style fixes, including |
Description of Pull Request:
Use the Babel standalone compiler to compile v-play examples and playground user supplied code, to allow ES6 support on older browsers (mainly IE)
Many of the documentation live examples do not work in IE 11, nor does ES6-ish code in the Playground.
Example (which should show the alert live example above the example code):
As a bonus of using babel, JavaScript compile errors provide better debugging (i.e line numbers, etc) in the Playground log:

Also adds
overflow-x: auto
to all live rendered examples. Fixes #1816Todo:
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)CHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes: