Skip to content

feat(form-checkbox): support custom switch styling #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 15, 2018

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Dec 14, 2018

Description of Pull Request:

Implements Boostrap V4.2 custom-switch style checkboxes.

Conditionally adds new CSS if not using v4.2 CSS

Adding support for switch styling involves only minor updates to the checkbox.

TODO:

  • Validate that new styles work with v4.1.3 CSS
  • Documentation (conditional on above working)
  • Tests

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #2293 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2293      +/-   ##
==========================================
+ Coverage   66.55%   66.56%   +0.01%     
==========================================
  Files         162      162              
  Lines        3169     3170       +1     
  Branches      879      880       +1     
==========================================
+ Hits         2109     2110       +1     
  Misses        779      779              
  Partials      281      281
Impacted Files Coverage Δ
src/components/form-checkbox/form-checkbox.js 100% <ø> (ø) ⬆️
...rc/components/form-checkbox/form-checkbox-group.js 100% <ø> (ø) ⬆️
src/mixins/form-radio-check.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a6bac5...c2d66a9. Read the comment docs.

@tmorehouse tmorehouse mentioned this pull request Dec 15, 2018
89 tasks
@tmorehouse tmorehouse changed the title feat(checkboxes): support custom switch styling feat(form-checkbox): support custom switch styling Dec 15, 2018
@tmorehouse tmorehouse merged commit 3508ea2 into dev Dec 15, 2018
@tmorehouse tmorehouse deleted the tmorehouse/checkbox-switch branch December 15, 2018 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant