Skip to content

fix(b-img-lazy): better initial inView check + new show prop (fixes #1755) #2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 3, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Jan 3, 2019

Description of Pull Request:

  • Wraps initial inView check in $nextTick to ensure DOM rendering is complete.
  • Listens to bubbled transtionend events to see of img is in viewport.
  • Listens for image load events (placeholder).
  • Adds new syncable prop show to force image to show.

Fixes #1755

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

…1755)

Wraps initial inView check in nextTick to ensure DOM is complete.

Adds new syncable prop `show` to force image to show

Fixes #1755
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #2382 into dev will increase coverage by 0.28%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2382      +/-   ##
==========================================
+ Coverage   67.52%   67.81%   +0.28%     
==========================================
  Files         167      167              
  Lines        3221     3222       +1     
  Branches      894      896       +2     
==========================================
+ Hits         2175     2185      +10     
+ Misses        767      757      -10     
- Partials      279      280       +1
Impacted Files Coverage Δ
src/components/image/img-lazy.js 75.67% <70.58%> (+25.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06cfb47...ac774cb. Read the comment docs.

@tmorehouse tmorehouse merged commit 2416bad into dev Jan 3, 2019
@tmorehouse tmorehouse deleted the tmorehouse/img-lazy branch January 3, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement of b-img-lazy component
1 participant