Skip to content

feat(dropdown): use provide and inject #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jan 10, 2019
Merged

feat(dropdown): use provide and inject #2431

merged 31 commits into from
Jan 10, 2019

Conversation

tmorehouse
Copy link
Member

Description of Pull Request:

Switch to provide an inject to dropdown item/btn for closing the dropdown, rather than root event.

First step towards supporting form controls in dropdowns

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #2431 into dev will increase coverage by 0.19%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2431      +/-   ##
==========================================
+ Coverage   71.95%   72.14%   +0.19%     
==========================================
  Files         168      168              
  Lines        3166     3163       -3     
  Branches      891      893       +2     
==========================================
+ Hits         2278     2282       +4     
+ Misses        648      641       -7     
  Partials      240      240
Impacted Files Coverage Δ
src/components/dropdown/dropdown-item-button.js 100% <100%> (ø) ⬆️
src/components/dropdown/dropdown-item.js 100% <100%> (ø) ⬆️
src/components/dropdown/dropdown.js 100% <100%> (ø) ⬆️
src/components/nav/nav-item-dropdown.js 85.71% <100%> (ø) ⬆️
src/mixins/dropdown.js 4.85% <16.66%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 273e8fd...c96a4d8. Read the comment docs.

@tmorehouse tmorehouse merged commit 3df90ea into dev Jan 10, 2019
@tmorehouse tmorehouse deleted the tmorehouse/ddown branch January 10, 2019 05:35
@tmorehouse tmorehouse mentioned this pull request Jan 10, 2019
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant