-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(tabs): various fixes and improvements (Fixes: #2327, #2148. Closes: #2403, #2180) #2442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2442 +/- ##
==========================================
- Coverage 72.19% 71.54% -0.66%
==========================================
Files 170 170
Lines 3165 3212 +47
Branches 893 912 +19
==========================================
+ Hits 2285 2298 +13
- Misses 641 662 +21
- Partials 239 252 +13
Continue to review full report at Codecov.
|
tmorehouse
added a commit
that referenced
this pull request
Jan 13, 2019
Fixes an issue introduced by PR #2442 where the classes were not being applied to the correct items.
This was referenced Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request:
this.$slots.default
to determine render order of child tab components (asthis.$children
doesn't guarantee node order)b-tab
, to allow individual tabs to be lazy rendered (b-tabs lazy prop takes precedence if true). a lazy tab will not render its default slot when not active but the b-tab wrapper elements will always be rendered to allow for transitions to work correctly.provide
andinject
, rather than usingthis.$parent
for parent-child communication.activate()
public method tob-tab
component (if tab isn't disabled, it will set this tab as active)deactivate()
public method tob-tab
component (deactivating will activate the first non-disabled tab)tabindex="0"
to the active tab so that screen reader users can focus the actively disaplayed tab so that it can be read by screen readers.Fixes: #2327
Fixes: #2148
Closes: #2403
Closes: #2180
Users (web authors) must also realize that tabs' controls are (or act like) buttons. One cannot place form controls inside a button/link per HTML/HTML5 standards. Stop trying to do this! 😝
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)CHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes: