feat(table): add support for transitions on tbody element (Closes #1821) #2450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renders the `<tbody>` element usingVue's `<transition-group>` component. Users can pass an object of props via the `tbodyTransitionProps` prop, and can also pass an object of transition event handlers via the `tbodyTransitionHandlers` props. When neither prop is specified, not transitions will occur.
Codecov Report
@@ Coverage Diff @@
## dev #2450 +/- ##
==========================================
- Coverage 71.52% 71.51% -0.01%
==========================================
Files 170 170
Lines 3217 3223 +6
Branches 910 913 +3
==========================================
+ Hits 2301 2305 +4
- Misses 665 666 +1
- Partials 251 252 +1
Continue to review full report at Codecov.
|
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request:
Renders the
<tbody>element usingVue's<transition-group>component (when transitions enabled).Users can pass an object of props via the
tbodyTransitionPropsprop, and can also pass an object of transition event handlers via thetbodyTransitionHandlersprops. Users must also set which field contains a unique value per row, viaprimary-keyso that transitions will happen correctly. The primary key field does not need to be present in the rendered table fields (it just needs to be present in the row data).When neither prop is specified, no transitions will occur.
Closes: #1821
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
devbranch, not themasterbranchfixes #xxxx[,#xxxx], where "xxxx" is the issue number)and adding a new feature, break them into separate PRs if at all possible.
Conventional Commits naming convention (i.e.
"fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
"chore: fix typo in docs", etc). This is very important, as the
CHANGELOGis generatedfrom these messages.
If new features/enhancement/fixes are added or changed:
package.jsonfor slot andevent changes)
keyboard only users? clickable items should be in the tab index, etc)
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:
suggestion issue first and wait for approval before working on it)