Skip to content

Add show class when visible. #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2017
Merged

Add show class when visible. #246

merged 2 commits into from
Apr 19, 2017

Conversation

charkins
Copy link
Contributor

When the show class is added in the after-enter handler of the vue
transition group it gets lost if an update is made asynchronously
in the modal shown handler: https://jsfiddle.net/bw7socb3/

When the show class is added in the after-enter handler of the vue
transition group it gets lost if an update is made asynchronously
in the modal shown handler:  https://jsfiddle.net/bw7socb3/
@pi0 pi0 requested a review from mosinve April 18, 2017 19:54
Copy link
Member

@mosinve mosinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for me, this solution more laconic and works well

@pi0 pi0 merged commit 7e22def into bootstrap-vue:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants