-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixed form-option disabled bug #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More closely aligns with proposed Bootstrap V4 dropdown keyboard navigation. (similar to how native select elements work) When dropdown opens, the dropdown menu is focused. Keyboard up/down will navigate the dropdown list. tabbing out of the dropdown will close the dropdown (and focus the next element based on normal tab flow). hitting ESC will also close the dropdown and refocus either the button or toggle button (depending on if the button is split or not). Also made the .sr-only "Toggle Dropdown" text a prop (toggleText) to allow for different languages.
Merge pull request #247 from tmorehouse/master
Merge in master fork
Changed feedback text block from class 'form-text' to 'form-control-feedback' to convey state. Added ARIA role="alert" to feedback div. Changed the target select from first child of content to querySelector() of first input element in content ref.
Fixed feedback class, & change choosing target ID
b-form-field fixed feedback class, & change choosing 'for' target ID …
Option `disabled` wasn't being factored into `formOptions()` computed result.
Option disabled wasn't being factored into formOptions() Return disabled = false if "falsey"
* Fix validation on 'offset' prop in Popover * Add 'targetOffset' prop to Popover * Fix lint tests - comment edit just included to permit commit
* Fix validation on 'offset' prop in Popover * Add 'targetOffset' prop to Popover * Fix lint tests - comment edit just included to permit commit
Merged latest master fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #244