-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixed default export of plugin #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
module.exports = components; | ||
module.exports.default = plugin; | ||
export * from './components'; | ||
export default plugin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'export' is only available in ES6 (use 'esversion: 6').
module.exports = components; | ||
module.exports.default = plugin; | ||
export * from './components'; | ||
export default plugin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'export' is only available in ES6 (use 'esversion: 6').
} | ||
|
||
module.exports = components; | ||
module.exports.default = plugin; | ||
export * from './components'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'export' is only available in ES6 (use 'esversion: 6').
} | ||
|
||
module.exports = components; | ||
module.exports.default = plugin; | ||
export * from './components'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'export' is only available in ES6 (use 'esversion: 6').
bCollapse: collapse, | ||
bCollapseToggle: collapseToggle, | ||
}; | ||
import * as components from './components'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
bCollapse: collapse, | ||
bCollapseToggle: collapseToggle, | ||
}; | ||
import * as components from './components'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
import bListGroupItem from './list-group-item' | ||
import bMedia from './media' | ||
import bModal from './modal' | ||
import bNav from './nav' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
Too many errors. (33% scanned).
import bListGroupItem from './list-group-item' | ||
import bMedia from './media' | ||
import bModal from './modal' | ||
import bNav from './nav' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
Too many errors. (33% scanned).
import bListGroup from './list-group' | ||
import bListGroupItem from './list-group-item' | ||
import bMedia from './media' | ||
import bModal from './modal' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bListGroup from './list-group' | ||
import bListGroupItem from './list-group-item' | ||
import bMedia from './media' | ||
import bModal from './modal' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bTags from './tags' | ||
import bListGroup from './list-group' | ||
import bListGroupItem from './list-group-item' | ||
import bMedia from './media' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bTags from './tags' | ||
import bListGroup from './list-group' | ||
import bListGroupItem from './list-group-item' | ||
import bMedia from './media' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bJumbotron from './jumbotron' | ||
import bTags from './tags' | ||
import bListGroup from './list-group' | ||
import bListGroupItem from './list-group-item' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bJumbotron from './jumbotron' | ||
import bTags from './tags' | ||
import bListGroup from './list-group' | ||
import bListGroupItem from './list-group-item' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bFormTextarea from './form-textarea' | ||
import bJumbotron from './jumbotron' | ||
import bTags from './tags' | ||
import bListGroup from './list-group' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bFormTextarea from './form-textarea' | ||
import bJumbotron from './jumbotron' | ||
import bTags from './tags' | ||
import bListGroup from './list-group' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bFormSelect from './form-select' | ||
import bFormTextarea from './form-textarea' | ||
import bJumbotron from './jumbotron' | ||
import bTags from './tags' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bFormSelect from './form-select' | ||
import bFormTextarea from './form-textarea' | ||
import bJumbotron from './jumbotron' | ||
import bTags from './tags' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bFormInput from './form-input' | ||
import bFormSelect from './form-select' | ||
import bFormTextarea from './form-textarea' | ||
import bJumbotron from './jumbotron' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bFormInput from './form-input' | ||
import bFormSelect from './form-select' | ||
import bFormTextarea from './form-textarea' | ||
import bJumbotron from './jumbotron' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bFormRadio from './form-radio' | ||
import bFormInput from './form-input' | ||
import bFormSelect from './form-select' | ||
import bFormTextarea from './form-textarea' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bFormRadio from './form-radio' | ||
import bFormInput from './form-input' | ||
import bFormSelect from './form-select' | ||
import bFormTextarea from './form-textarea' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bFormCheckbox from './form-checkbox' | ||
import bFormRadio from './form-radio' | ||
import bFormInput from './form-input' | ||
import bFormSelect from './form-select' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bFormCheckbox from './form-checkbox' | ||
import bFormRadio from './form-radio' | ||
import bFormInput from './form-input' | ||
import bFormSelect from './form-select' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bDropdownSelect from './dropdown-select' | ||
import bFormCheckbox from './form-checkbox' | ||
import bFormRadio from './form-radio' | ||
import bFormInput from './form-input' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bDropdownSelect from './dropdown-select' | ||
import bFormCheckbox from './form-checkbox' | ||
import bFormRadio from './form-radio' | ||
import bFormInput from './form-input' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bDropdown from './dropdown' | ||
import bDropdownSelect from './dropdown-select' | ||
import bFormCheckbox from './form-checkbox' | ||
import bFormRadio from './form-radio' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bDropdown from './dropdown' | ||
import bDropdownSelect from './dropdown-select' | ||
import bFormCheckbox from './form-checkbox' | ||
import bFormRadio from './form-radio' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bCollapseToggle from './collapse-toggle' | ||
import bDropdown from './dropdown' | ||
import bDropdownSelect from './dropdown-select' | ||
import bFormCheckbox from './form-checkbox' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bCollapse from './collapse' | ||
import bCollapseToggle from './collapse-toggle' | ||
import bDropdown from './dropdown' | ||
import bDropdownSelect from './dropdown-select' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bCollapseToggle from './collapse-toggle' | ||
import bDropdown from './dropdown' | ||
import bDropdownSelect from './dropdown-select' | ||
import bFormCheckbox from './form-checkbox' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
import bCollapse from './collapse' | ||
import bCollapseToggle from './collapse-toggle' | ||
import bDropdown from './dropdown' | ||
import bDropdownSelect from './dropdown-select' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
@nddery this looks great |
LGTM |
Just released |
Fixes the issues reported in #26 (comment).
Moved all components export into it's own
components.js
file because it was a lot of duplication otherwise, not the cleanest solution (having a file that just import/export) but it works.@pi0 @sourcec0de this would result in
v0.3.9
if your good with these changes, or do you have another approach to suggest ?