Skip to content

Fixed default export of plugin #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2016
Merged

Fixed default export of plugin #27

merged 2 commits into from
Nov 20, 2016

Conversation

nddery
Copy link
Contributor

@nddery nddery commented Nov 20, 2016

Fixes the issues reported in #26 (comment).

Moved all components export into it's own components.js file because it was a lot of duplication otherwise, not the cleanest solution (having a file that just import/export) but it works.

@pi0 @sourcec0de this would result in v0.3.9 if your good with these changes, or do you have another approach to suggest ?

module.exports = components;
module.exports.default = plugin;
export * from './components';
export default plugin;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'export' is only available in ES6 (use 'esversion: 6').

module.exports = components;
module.exports.default = plugin;
export * from './components';
export default plugin;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'export' is only available in ES6 (use 'esversion: 6').

}

module.exports = components;
module.exports.default = plugin;
export * from './components';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'export' is only available in ES6 (use 'esversion: 6').

}

module.exports = components;
module.exports.default = plugin;
export * from './components';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'export' is only available in ES6 (use 'esversion: 6').

bCollapse: collapse,
bCollapseToggle: collapseToggle,
};
import * as components from './components';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

bCollapse: collapse,
bCollapseToggle: collapseToggle,
};
import * as components from './components';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

import bListGroupItem from './list-group-item'
import bMedia from './media'
import bModal from './modal'
import bNav from './nav'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
Too many errors. (33% scanned).

import bListGroupItem from './list-group-item'
import bMedia from './media'
import bModal from './modal'
import bNav from './nav'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
Too many errors. (33% scanned).

import bListGroup from './list-group'
import bListGroupItem from './list-group-item'
import bMedia from './media'
import bModal from './modal'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bListGroup from './list-group'
import bListGroupItem from './list-group-item'
import bMedia from './media'
import bModal from './modal'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bTags from './tags'
import bListGroup from './list-group'
import bListGroupItem from './list-group-item'
import bMedia from './media'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bTags from './tags'
import bListGroup from './list-group'
import bListGroupItem from './list-group-item'
import bMedia from './media'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bJumbotron from './jumbotron'
import bTags from './tags'
import bListGroup from './list-group'
import bListGroupItem from './list-group-item'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bJumbotron from './jumbotron'
import bTags from './tags'
import bListGroup from './list-group'
import bListGroupItem from './list-group-item'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bFormTextarea from './form-textarea'
import bJumbotron from './jumbotron'
import bTags from './tags'
import bListGroup from './list-group'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bFormTextarea from './form-textarea'
import bJumbotron from './jumbotron'
import bTags from './tags'
import bListGroup from './list-group'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bFormSelect from './form-select'
import bFormTextarea from './form-textarea'
import bJumbotron from './jumbotron'
import bTags from './tags'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bFormSelect from './form-select'
import bFormTextarea from './form-textarea'
import bJumbotron from './jumbotron'
import bTags from './tags'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bFormInput from './form-input'
import bFormSelect from './form-select'
import bFormTextarea from './form-textarea'
import bJumbotron from './jumbotron'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bFormInput from './form-input'
import bFormSelect from './form-select'
import bFormTextarea from './form-textarea'
import bJumbotron from './jumbotron'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bFormRadio from './form-radio'
import bFormInput from './form-input'
import bFormSelect from './form-select'
import bFormTextarea from './form-textarea'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bFormRadio from './form-radio'
import bFormInput from './form-input'
import bFormSelect from './form-select'
import bFormTextarea from './form-textarea'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bFormCheckbox from './form-checkbox'
import bFormRadio from './form-radio'
import bFormInput from './form-input'
import bFormSelect from './form-select'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bFormCheckbox from './form-checkbox'
import bFormRadio from './form-radio'
import bFormInput from './form-input'
import bFormSelect from './form-select'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bDropdownSelect from './dropdown-select'
import bFormCheckbox from './form-checkbox'
import bFormRadio from './form-radio'
import bFormInput from './form-input'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bDropdownSelect from './dropdown-select'
import bFormCheckbox from './form-checkbox'
import bFormRadio from './form-radio'
import bFormInput from './form-input'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bDropdown from './dropdown'
import bDropdownSelect from './dropdown-select'
import bFormCheckbox from './form-checkbox'
import bFormRadio from './form-radio'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bDropdown from './dropdown'
import bDropdownSelect from './dropdown-select'
import bFormCheckbox from './form-checkbox'
import bFormRadio from './form-radio'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bCollapseToggle from './collapse-toggle'
import bDropdown from './dropdown'
import bDropdownSelect from './dropdown-select'
import bFormCheckbox from './form-checkbox'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bCollapse from './collapse'
import bCollapseToggle from './collapse-toggle'
import bDropdown from './dropdown'
import bDropdownSelect from './dropdown-select'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bCollapseToggle from './collapse-toggle'
import bDropdown from './dropdown'
import bDropdownSelect from './dropdown-select'
import bFormCheckbox from './form-checkbox'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

import bCollapse from './collapse'
import bCollapseToggle from './collapse-toggle'
import bDropdown from './dropdown'
import bDropdownSelect from './dropdown-select'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

@sourcec0de
Copy link

@nddery this looks great

@pi0
Copy link
Member

pi0 commented Nov 20, 2016

LGTM

@pi0 pi0 merged commit 75320e8 into bootstrap-vue:master Nov 20, 2016
@nddery
Copy link
Contributor Author

nddery commented Nov 20, 2016

Just released v.0.3.9, sorry for the troubles and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants