Skip to content

feat(table): make some slots available either as scoped or unscoped #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 1, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Mar 1, 2019

Description of Pull Request:

In versions of Vue prior to 2.6, scoped slots and un-scoped slots were separate entities. Now all regular names (un-scoped) slots are also available in the $scopedSlots as functions (which provide render speed optimizations, over regular $slots). This PR makes optionally scoped slots work with Vue 2.5.x.

The following slots are now all available as optionally scoped:

  • colgroup
  • thead-top
  • HEAD_<field_key>
  • FOOT_<field_key>
  • empty
  • emptyfiltered
  • top-row
  • bottom-row

When the user provides a slot-scope, these slots will be called as $scopedSlots, and passed a slot scope context.

Uses the new normalize-slots mixin.

Will also introduce optional scoped slots into other components (such as modal) for passing methods to the slots in a separate PR.

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

In version of Vue prior to 2.6, scoped slots and un-scoped slots were separate entities.  Now all regular names (un-scoped) slots are also available in the `$scopedSlots` as functions (which provide render speed optimizations, over regular $slots).

The non item slots are now all available as optionally scoped:

- `colgroup`
- `thead-top`
- `HEAD_<field_key>`
- 'FOOT_<field_key>`
- `empty`
- `emptyfiltered`

When the user provides a slot-scope, these slots will be called as $scopedSlots, and passed a slot scope context.

Uses the new normalize-slots mixin.
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #2740 into dev will increase coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2740      +/-   ##
==========================================
+ Coverage   74.85%   74.89%   +0.03%     
==========================================
  Files         175      176       +1     
  Lines        3194     3195       +1     
  Branches      943      942       -1     
==========================================
+ Hits         2391     2393       +2     
+ Misses        586      585       -1     
  Partials      217      217
Impacted Files Coverage Δ
src/mixins/normalize-slot.js 100% <100%> (ø)
src/components/table/table.js 74.16% <81.81%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb7939...278fe2a. Read the comment docs.

@tmorehouse tmorehouse requested review from pi0 and jacobmllr95 March 1, 2019 02:58
@tmorehouse tmorehouse marked this pull request as ready for review March 1, 2019 03:33
@iliveoncaffiene

This comment has been minimized.

@tmorehouse

This comment has been minimized.

@tmorehouse tmorehouse merged commit ab7937e into dev Mar 1, 2019
@tmorehouse tmorehouse deleted the tmorehouse/table-scoped branch March 1, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants