Allow container-fluid inside jumbotron #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds Boolean prop `container-fluid` to allow for fluid container inside jumbotron http://v4-alpha.getbootstrap.com/components/jumbotron/
pi0
reviewed
Apr 25, 2017
| @@ -16,6 +16,10 @@ | |||
| type: Boolean, | |||
| default: false | |||
| }, | |||
| containerFluid: { | |||
There was a problem hiding this comment.
please rename it to just fluid to keep consistent with other components :)
There was a problem hiding this comment.
There is already another fluid prop for the main jumbotron div though.
The jumbotron itself can be fluid (jumbotron-fluid), and the container inside can also be fluid (container-fluid). So there are two things in the jumbotron that can be fluid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Boolean prop
container-fluidto allow for fluid container inside jumbotronhttp://v4-alpha.getbootstrap.com/components/jumbotron/