Skip to content

fix(table): fix range selection #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Mar 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/components/table/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1188,6 +1188,16 @@ as read-only.**
<!-- b-table-selectable.vue -->
```

When table is selectable, it will have class `b-table-selectable`, and one of the following three
classes (depending on which mode is in use), on the `<table>` element:

- `b-table-select-single`
- `b-table-select-multi`
- `b-table-select-range`

When at least one row is selected the class `b-table-selecting` will be active on the `<table>`
element.

**Notes:**

- _Paging, filtering, or sorting will clear the selection. The `row-selected` event will be emitted
Expand Down
14 changes: 11 additions & 3 deletions src/components/table/_table.scss
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,15 @@
}

/* b-table: selectable rows */
table.b-table.b-table-selectable > tbody > tr {
cursor: pointer;
// user-select: none;
.b-table.table.b-table-selectable {
& > tbody > tr {
cursor: pointer;
}

&.b-table-selecting {
// Disabled text-selection when in mode range when at least one row selected
&.b-table-select-range > tbody > tr {
user-select: none;
}
}
}
50 changes: 36 additions & 14 deletions src/components/table/helpers/mixin-selectable.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import looseEqual from '../../../utils/loose-equal'
import { isArray } from '../../../utils/array'
import { isArray, arrayIncludes } from '../../../utils/array'
import sanitizeRow from './sanitize-row'

export default {
Expand All @@ -23,6 +23,29 @@ export default {
selectedLastRow: -1
}
},
computed: {
selectableTableClasses() {
const selectable = this.selectable
const isSelecting = selectable && this.selectedRows && this.selectedRows.some(Boolean)
return {
'b-table-selectable': selectable,
[`b-table-select-${this.selectMode}`]: selectable,
'b-table-selecting': isSelecting
}
},
selectableTableAttrs() {
return {
'aria-multiselectable': this.selectableIsMultiSelect
}
},
selectableIsMultiSelect() {
if (this.selectable) {
return arrayIncludes(['range', 'multi'], this.selectMode) ? 'true' : 'false'
} else {
return null
}
}
},
watch: {
computedItems(newVal, oldVal) {
// Reset for selectable
Expand Down Expand Up @@ -72,17 +95,18 @@ export default {
isRowSelected(idx) {
return Boolean(this.selectedRows[idx])
},
rowSelectedClasses(idx) {
if (this.selectable) {
const rowSelected = this.isRowSelected(idx)
const base = this.dark ? 'bg' : 'table'
const variant = this.selectedVariant
return {
'b-row-selected': rowSelected,
[`${base}-${variant}`]: rowSelected && variant
}
} else {
return {}
selectableRowClasses(idx) {
const rowSelected = this.isRowSelected(idx)
const base = this.dark ? 'bg' : 'table'
const variant = this.selectedVariant
return {
'b-table-row-selected': this.selectable && rowSelected,
[`${base}-${variant}`]: this.selectable && rowSelected && variant
}
},
selectableRowAttrs(idx) {
return {
'aria-selected': !this.selectable ? null : this.isRowSelected(idx) ? 'true' : 'false'
}
},
clearSelected() {
Expand Down Expand Up @@ -125,7 +149,6 @@ export default {
idx <= Math.max(this.selectedLastRow, index);
idx++
) {
// this.$set(this.selectedRows, idx, true)
selectedRows[idx] = true
}
selected = true
Expand All @@ -138,7 +161,6 @@ export default {
this.selectedLastRow = selected ? index : -1
}
}
// this.$set(this.selectedRows, index, selected)
selectedRows[index] = selected
this.selectedRows = selectedRows
}
Expand Down
7 changes: 3 additions & 4 deletions src/components/table/helpers/mixin-tbody-row.js
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ export default {
const hasRowClickHandler = this.$listeners['row-clicked'] || this.selectable
const $detailsSlot = $scoped['row-details']
const rowShowDetails = Boolean(item._showDetails && $detailsSlot)
const rowSelected = this.isRowSelected(rowIndex) /* from selctable mixin */

// We can return more than one TR if rowDetails enabled
const $rows = []
Expand Down Expand Up @@ -244,7 +243,7 @@ export default {
key: `__b-table-row-${rowKey}__`,
class: [
this.rowClasses(item),
this.rowSelectedClasses(rowIndex),
this.selectableRowClasses(rowIndex),
{
'b-table-has-details': rowShowDetails
}
Expand All @@ -256,8 +255,8 @@ export default {
'aria-describedby': detailsId,
'aria-owns': detailsId,
'aria-rowindex': ariaRowIndex,
'aria-selected': this.selectable ? (rowSelected ? 'true' : 'false') : null,
role: 'row'
role: 'row',
...this.selectableRowAttrs(rowIndex)
},
on: {
// TODO: only instatiate handlers if we have registered listeners (except row-clicked)
Expand Down
Loading